-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy warnings #267
Fix clippy warnings #267
Conversation
e1c5818
to
ee95dc5
Compare
Rebased to see if it fixes the CI issue. |
Maybe the runner has a different rust version than your local version?
|
I built locally on x86_64 and aarch64 using rust 1.64.0 and rust 1.61.0 (the version in the Bottlerocket SDK) prior to the rebase, but the weird linking error is still occurring. Since this isn't a high priority I'll drop it into draft and we can poke at it a bit more. |
ee95dc5
to
f8d3123
Compare
Dropped |
Is this the linking error you saw? https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/3184235579/jobs/5192405098#step:5:343 Those look to have started a few hours ago 👀 |
f8d3123
to
f1ed146
Compare
The very same. We merged a couple dependabot updates this morning, but each of those were rebased and retested prior to merge. Checking to see if bumping the builder image helps. |
f1ed146
to
b641327
Compare
Temporarily taking caching out of the picture to make sure we aren't running out of disk space. |
b641327
to
80ea2fe
Compare
Removed testing commit and rebased now that we've cleared the cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed the controller / resources and all looks well! Thanks Patrick! 👏🏼
Testing done:
Updated small group of 3 bottlerocket nodes. (thanks, @gthao313!)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.